Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request]: support for both us-imperial and uk-imperial when using .to("best", "unit") method. #676

Open
gorbypark opened this issue Jun 30, 2024 · 1 comment
Open

[Feature request]: support for both us-imperial and uk-imperial when using .to("best", "unit") method. #676

gorbypark opened this issue Jun 30, 2024 · 1 comment
Assignees
@jonahsnider
Labels
enhancement New feature or request

Comments

@gorbypark
Copy link

The title says it all, really. I'm not even sure if .to("best", "imperial") is using US or UK imperial at the moment, but I have the need to display and convert between both.

Thanks for the great library!
@jonahsnider
Copy link
Owner

I believe "imperial" corresponds to US customary units. Which is confusing but my reasoning was that more people are familiar with the term "imperial" than "US customary" 🤷‍♂️.

Adding in support for UK imperial units should be fairly easy to do. What specific units did you have in mind as being different from the current US customary ones?

@jonahsnider jonahsnider added the enhancement New feature or request label Jul 1, 2024
@jonahsnider jonahsnider self-assigned this Jul 1, 2024
@jonahsnider jonahsnider mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahsnider jonahsnider

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonahsnider @gorbypark