Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data bigint conversion error due to ratio is not an integer #558

Open
carlocorradini opened this issue Oct 24, 2022 · 4 comments
Open

Data bigint conversion error due to ratio is not an integer #558

carlocorradini opened this issue Oct 24, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@carlocorradini
Copy link

carlocorradini commented Oct 24, 2022

All data conversions fail if using bigint due to Conversion for [UNIT] to [UNIT] cannot be calculated as a BigInt because the conversion ratio is not an integer error. 
Even a simple operation like this fails:

convert(1024n, 'B').to('KiB');
@carlocorradini carlocorradini changed the title Data bigint conversion error due to ration is not an integer Data bigint conversion error due to ratio is not an integer Oct 24, 2022
@jonahsnider jonahsnider added the bug Something isn't working label Oct 28, 2022
@jonahsnider jonahsnider self-assigned this Oct 28, 2022
@jonahsnider
Copy link
Owner

This is an issue that I'm aware of. When I'm free in a few days I can investigate if improving this is feasible. I'll also add that this isn't an issue for all conversions (ex. convert(20n, 'hours').to('minutes') works), but is a problem for many others.

@carlocorradini
Copy link
Author

Thanks 🙏

@carlocorradini
Copy link
Author

Hey, @jonahsnider any update? Thanks 🥳

@jonahsnider
Copy link
Owner

Sorry, I've been caught up with other things and I'm not sure when I'll have the time to look into this. I suspect that the fix is going to require a fair deal of work, which is not ideal as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants