Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute gethostbyname() in the Tracer constructor is not optimal #128

Open
jackwoods opened this issue Aug 16, 2023 · 2 comments
Open

execute gethostbyname() in the Tracer constructor is not optimal #128

jackwoods opened this issue Aug 16, 2023 · 2 comments

Comments

@jackwoods
Copy link

jackwoods commented Aug 16, 2023

Suggestion: can set via config.
If not set, then call this function (maybe not to call it by default).

@sergeyklay
Copy link
Collaborator

Hi @jackwoods!

Thank you for pointing out the use of gethostbyname() in the Tracer constructor. We value your insights in optimizing and enhancing the project.

As you might be aware, jaeger-client-php is an open-source project, with many of us contributing on a voluntary basis in our spare time. I'd be grateful if you could take a more active role in improving this part of the code.

If you're up for it, it would be great if you could submit a pull request with your proposed fix. Please ensure that your change maintains backward compatibility for existing users and that it's covered by tests. This helps us ensure the library's stability and reliability for all users.

Thanks again for your feedback, and we look forward to your continued involvement in the project!

@jackwoods
Copy link
Author

Will try, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants