Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"SHOW" on CW in web interface not expanding post #715

Open
futzle opened this issue May 27, 2024 · 2 comments · May be fixed by #716
Open

"SHOW" on CW in web interface not expanding post #715

futzle opened this issue May 27, 2024 · 2 comments · May be fixed by #716

Comments

@futzle
Copy link
Contributor

futzle commented May 27, 2024

A reader of fedi.vision (Takahe 0.10) noticed this small issue with expanding CWs in the web view interface.

Example page: https://fedi.vision/@[email protected]/replies/

  1. Go to above page. (Firefox but also reported on other browsers.)
  2. Find a post with a CW.
  3. Click on SHOW.

Expected result: Post is expanded.

Actual result: no change is visible on the web page; it remains collapsed.

Here's what is happening in the Javascript console:

Document.querySelectorAll: '.summary-{self.id} .summary' is not a valid selector [hyperscript.min.2e9b5242ff02.js:1:51625](https://fedi.vision/static/js/hyperscript.min.2e9b5242ff02.js)
hypertrace /// [hyperscript.min.2e9b5242ff02.js:1:21927](https://fedi.vision/static/js/hyperscript.min.2e9b5242ff02.js)
  -> on click or keyup   - 
<div class="summary" _="on click or keyup[key is…d} .content/> then halt" tabindex="0">

The target <div> itself has this class:

<div class="post  summary-{self.id}" data-takahe-id="317611159932175328" role="article" tabindex="0">
...
</div>

Is {self.id} meant to have been substituted with something during rendering of the HTML page? All the CW'd posts on the page have the same class.

The post itself federates to other servers fine, and it views fine in mobile clients. This is just a problem with the web view.

@futzle
Copy link
Contributor Author

futzle commented May 27, 2024

Suspect this line here:

return "summary-{self.id}"

@shuuji3 shuuji3 linked a pull request May 27, 2024 that will close this issue
@futzle
Copy link
Contributor Author

futzle commented May 28, 2024

Confirming that #716 applied manually to my instance fixes the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant