Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 57 compatibility #2

Open
cru121 opened this issue Aug 24, 2017 · 14 comments
Open

Firefox 57 compatibility #2

cru121 opened this issue Aug 24, 2017 · 14 comments

Comments

@cru121
Copy link

cru121 commented Aug 24, 2017

This add-on currently shows as legacy in Firefox and got disabled. Any chance for an update? Any successor add-ons with similar functionality you could recommend?

@johntyree
Copy link
Owner

Hey. Well that sucks. :(

I stopped using Firefox when they killed support for vimperator and haven't spent much time looking at it. I think they switched to some new api that doesn't support a lot of addons' better features. It's sad. :(

If you want to do the legwork of figuring out why it's disabled and what needs to change, I can spend a little time trying to make work.

@dscorbett
Copy link

I wrote a WebExtension version of this add-on. It is slower than this one but I don’t know if the new APIs allow anything faster.

@johntyree
Copy link
Owner

Sweet. Thanks!

@johntyree
Copy link
Owner

Just out of curiousity, I tried my original add-on in a clean firefox install (57) and it worked great. I'm wondering what the issue is? @cru121 can you not just reenable it?

Of course you can also use the WebExtension version that @dscorbett made too.

@johntyree
Copy link
Owner

Scratch that, I have version 55.

Guess this is dead 💀

@johntyree
Copy link
Owner

@dscorbett I couldn't find yours on addons.mozilla.org. If you put it there, I'll update my readme to point to it.

Alternatively, we can replace mine with yours and I can change the author credits.

Or I'll rewrite someday

@dscorbett
Copy link

I haven’t put it on AMO yet: there are still some changes I’m thinking of making. When I publish it, I’ll comment here.

@dscorbett
Copy link

I have published the WebExtension: https://addons.mozilla.org/en-US/firefox/addon/view-link-as-text/.

@johntyree
Copy link
Owner

Tried it out. Works great! I'll update the description in my original addon to point to this one.

You should probably change the accelerator key from T to X or something, since T overlaps with "Open in new [T]ab."

@johntyree
Copy link
Owner

johntyree commented Nov 8, 2017

Old addon page is updated. https://addons.mozilla.org/en-US/firefox/addon/view-as-text/

@dscorbett
Copy link

You should probably change the accelerator key from T to X or something, since T overlaps with "Open in new [T]ab."

It has no accelerator key: WebExtensions don’t support them. The extra T key comes from this XUL add-on.

@cru121
Copy link
Author

cru121 commented Nov 8, 2017

Thanks all.

@johntyree
Copy link
Owner

@dscorbett which XUL addon?

@dscorbett
Copy link

Your add-on, the one in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants