Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire.begin() call in init_priv() should be removed. #81

Open
pdppdp opened this issue Oct 16, 2024 · 0 comments
Open

Wire.begin() call in init_priv() should be removed. #81

pdppdp opened this issue Oct 16, 2024 · 0 comments

Comments

@pdppdp
Copy link

pdppdp commented Oct 16, 2024

Only higher levels should call Wire.begin(), never in a library.

This call resets the pins used and the speed, if they were initialized previously. If they are be changed, it is for reasons that are of no business for a supporting library to change.

I understand some might raise compatibility issues, yet there is no way around the fact that this has been broken in this way from the get go. Longstanding bugs still should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant