Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block setting org.zectl.org.zectl:<property> #45

Open
lethedata opened this issue Feb 14, 2022 · 1 comment
Open

Block setting org.zectl.org.zectl:<property> #45

lethedata opened this issue Feb 14, 2022 · 1 comment
Labels
Priority: Low Status: Help Wanted Extra attention is needed

Comments

@lethedata
Copy link
Contributor

zectl set org.zectl:<property>=<value> counts as a valid property leading to an org.zectl.org.zectl: entry.

I'm not sure if these entries lead to anything beyond a dud entry but zectl as it depends on how zectl and it's plugins are filtered. zectl get show the property and they can be set independent from the actual entries so it might lead to some issues.

I was able to remove the property as mentioned in #16 (comment).

TOFIX: 'zectl' needs an 'unset' subcommand

Are you just looking to "erase" a property?

be_active_ds="$(zpool get bootfs -H -o value)"
be_root="${be_active_ds%/*}"
zfs inherit org.zectl:yourprop "${be_root}"
@johnramsden
Copy link
Owner

Right now zectl set is basically a wrapper around zfs set, so this is working as expected. However this should probably be fixed so that if you add the prefix it issues a warning or ignores it and only has the prefix once.

@johnramsden johnramsden added Status: Help Wanted Extra attention is needed Priority: Low labels Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Status: Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants