Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to pass through tools:* attrs to facilitate manifest merging. #125

Open
dbachelder opened this issue Jul 7, 2014 · 1 comment
Milestone

Comments

@dbachelder
Copy link
Contributor

I can manually fix this by adding, tools:node="replace" on the application node along with the xmlns:tools="http://schemas.android.com/tools" at the root of the manifest. But of course it's all blown away as soon as the manifest gets regenerated.

Error:(16, 45) Execution failed for task ':pro:processStageDebugManifest'.
> Manifest merger failed : Attribute application@icon value=(@drawable/logo) from AndroidManifest.xml:16:45
    is also present at com.github.dmytrodanylyk.circular-progress-button:library:1.0.4:4:18 value=(@drawable/ic_launcher)
    Suggestion: add 'tools:replace="android:icon"' to <application> element at AndroidManifest.xml:16:5 to override
@johncarl81
Copy link
Owner

Right now the namespaces are hardcoded into the org.androidtransfuse.model.manifest.package-info class. I wonder if we could make this more dynamic... like it would pick up a base set and add to it any others that were already defined in the existing manifest.

I thought the manifest merging was designed to honor additional parameters that you introduce into the manifest. I'll have to dig into this to figure out why this parameter is not preserved.

As we discussed, for the time being, you can turn off manifest overwriting by the following gradle configuration:

apt {
    arguments {
        androidManifestFile variant.processResources.manifestFile
        transfuseManifestProcessing 'off'
    }
}

another option for transfuseManifestProcessing is 'log'

@johncarl81 johncarl81 added this to the 0.3.0 Release milestone Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants