Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to parse HIGHCHARUNICODE compiler directive #4

Open
d-c-d opened this issue Jun 13, 2020 · 0 comments
Open

Failure to parse HIGHCHARUNICODE compiler directive #4

d-c-d opened this issue Jun 13, 2020 · 0 comments

Comments

@d-c-d
Copy link

d-c-d commented Jun 13, 2020

The examples that come with the Object Pascal Handbook yield the following parse error

ObjectPascalHandbook/06/CharTest/CharTestForm.pas
35:{$HIGHCHARUNICODE ON}

This example can be found here on github:
https://github.com/MarcoDelphiBooks/ObjectPascalHandbook/tree/master/06/CharTest
HIGHCHARUNICODE is described here:
http://docwiki.embarcadero.com/RADStudio/Sydney/en/HIGHCHARUNICODE_directive_(Delphi)

Assuming that we need to add
_directiveTypes["HIGHCHARUNICODE"] = DirectiveType.Ignored;
to the TokenFilter constructor in TokenFilter.cs
d-c-d pushed a commit to d-c-d/dgrok that referenced this issue Jun 14, 2020
Fix issue Failure to parse HIGHCHARUNICODE compiler directive
c1e519b 
Fix issue Failure to parse HIGHCHARUNICODE compiler directive
  joewhite#4

Add an ignored directive type for "HIGHCHARUNICODE"]
to Source/DGrok.Framework/Framework/TokenFilter.cs

Add a new test case HighCharUnicodeCompilerDirectivesAreIgnored()
to verifiy that {$HIGHCHARUNICODE ... } is ignored
  ( doesn't really check the value of the parameter ON/OFF )
@d-c-d d-c-d mentioned this issue Jun 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d-c-d