From e5f14977326cc9c5e2376ec74b27bc0a5379f54f Mon Sep 17 00:00:00 2001 From: tomasIFL Date: Tue, 19 Jan 2021 10:32:42 +0100 Subject: [PATCH] timeout variable hoisting fix timeout variable is hoisting and replacing scope from the real timeout variable which we wanted to clearTimeout in ws.onclose --- reconnecting-websocket.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reconnecting-websocket.js b/reconnecting-websocket.js index 0cd4332..c730686 100644 --- a/reconnecting-websocket.js +++ b/reconnecting-websocket.js @@ -266,11 +266,11 @@ eventTarget.dispatchEvent(generateEvent('close')); } - var timeout = self.reconnectInterval * Math.pow(self.reconnectDecay, self.reconnectAttempts); + var timeoutNumber = self.reconnectInterval * Math.pow(self.reconnectDecay, self.reconnectAttempts); setTimeout(function() { self.reconnectAttempts++; self.open(true); - }, timeout > self.maxReconnectInterval ? self.maxReconnectInterval : timeout); + }, timeoutNumber > self.maxReconnectInterval ? self.maxReconnectInterval : timeoutNumber); } }; ws.onmessage = function(event) {