Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't fullscreen images in full content version #352

Closed
Monirzadeh opened this issue Sep 10, 2024 · 5 comments
Closed

can't fullscreen images in full content version #352

Monirzadeh opened this issue Sep 10, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Monirzadeh
Copy link

Steps to Reproduce

  1. Open a feed with image
  2. Tap on image
  3. You see image get fullscreen
  4. Tap on icon on top right to fetch full content
  5. Tap on same image in full content
  6. As you see image not get fullscreen anymore

Expected behavior

See image of article in fullscreen expected to work on normal and full content mode

Screenshots or screen recording

No response

Device, Operating system, and app version

Capy Reader 2024.09.1043-dev

@Monirzadeh Monirzadeh added the bug Something isn't working label Sep 10, 2024
@Monirzadeh Monirzadeh changed the title can't fullscreen images in fetch full content version can't fullscreen images in full content version Sep 11, 2024
@jocmp
Copy link
Owner

jocmp commented Sep 13, 2024

hey @Monirzadeh do you have an example feed you can link?

@Monirzadeh
Copy link
Author

@jocmp
you can check any post that has image in full content mode of this feed

@jocmp
Copy link
Owner

jocmp commented Sep 17, 2024

I have a partial fix I'll ship in the next version as seen below. It works when the parser finds an image successfully, but other times the parser I use still doesn't find the lead image.

@jocmp
Copy link
Owner

jocmp commented Dec 3, 2024

Merging this into #506. I have a way to fix these now.

@jocmp jocmp closed this as completed Dec 3, 2024
@Monirzadeh
Copy link
Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants