Rewrite adding support for namespacing, UTMV cookie and unit testings. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able is not set, it is set to null.
…ng, UTMV support and PHPUnit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I'd been using your cookie parser for some time and decided to take it a couple of steps farther in terms of form and function. Basically, I made a class for each cookie and a "Tracker" class to act as the universal interface to the data contained in the cookies. I added support for the UTMV cookie and the CustomVars that it stores. I also added PHPUnit tests. You'll also notice, of course, that I put things in a namespacing scheme and included and autoloader.
I really appreciate the work you put in here and hope you will like the changes I've implemented. I think this would be a useful component for a variety of web analytics projects/dashboards in PHP. I could see this bundled in a Wordpress plugin as well and if you're interested, it's a side project I'd be interested in pursuing.
All my best,
Roger Webb