Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use logging api #79

Open
PeterNSteinmetz opened this issue Jul 26, 2023 · 2 comments
Open

use logging api #79

PeterNSteinmetz opened this issue Jul 26, 2023 · 2 comments

Comments

@PeterNSteinmetz
Copy link
Contributor

Another change which would make combinato function better as a library is to use logging statements rather than print statements.

The same console output as presently can be achieved for the command line commands, if desired, by configuring a logging format to just give the message.
@jniediek
Copy link
Owner

I completely agree, it's a great and natural idea I think. Would you be willing to create a pull request?
Cheers,
Johannes

@PeterNSteinmetz
Copy link
Contributor Author

I will begin moving in that direction if I have other changes to incorporate. Cheers, Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PeterNSteinmetz @jniediek