-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons not working #52
Comments
There should be a selector on that field. |
Something is not binding properly. Can you check your browser's developer tools on the console tab for errors on initial page load? I know firefox doesn't give as good error messages as chrome in this case. |
I tried on chrome. There are a bunch of errors relating to MeatPack plugin but no mention of TabOrder. Are the icons supposed to be on the local machine (Pi) and if so where can I look to confirm they are there? |
Ah, I just spotted some messages relating to font-awsome |
Ah, that preload error is common, unrelated to the issue. If you disable meat pack does anything change? Force refresh your browser so cache isn't involved. Also check octoprint.log for any errors. |
Disabling MeatPack gets rid of all the console errors but no change to TabOrder :-( |
It's been a while since I've used this plugin, let me check to see what might be going on with it. What version of OctoPrint are you running and what other plugins besides MeatPack do you have installed? |
I am running OctoPrint V1.6.1 on OctoPi 0.18.0. I have a bunch of plugins installed. I will try disabling them. |
Here are my plugins (couldn't find a better way to list them): |
is that after updating just now? |
Not sure what you mean about updating? Tasmota plugin is 1.0.4 |
thanks, just wanted to make sure it wasn't version 1.1.0 that I just released an hour ago... try this for me, use the plugin manager to clean up the plugin's settings with the little eraser icon and see if that changes anything. it could be settings corruption. double-check the developer console when opening the pop-up to edit the tab settings. |
No change. I got no console messages when I openned the TabOrder edit window. |
I am not seeing any selector. I am using Firefox but have also tried Chrome.
…
There should be a selector on that field.
|
Only thing I can think of now is disabling all other plugins and see if it still doesn't work. |
I disabled all my plugins and then gradually re-enabled them. Success! The plugin causing the problem is... drum roll please... OctoDash Companion. With this plugin enabled the icons are displayed properly, I just can't select any new ones. |
So with that plugin disabled the tab order icon selector works? |
Correct.
DG
…
So with that plugin disabled the tab order icon selector works?
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
-----------------------------------------------------------
David Griffiths ***@***.***
Digital Graphics P/L http://www.digitalgraphics.com.au
Sydney, Australia +61 2 4567 8999
-----------
Australian agents for:
E-LAB computers - AVR Pascal and In Circuit programmers
Logical Systems - programming adapters
Intronix - LogicPort 34 channel Logic Analyser
|
Technically, yes you could probably do a custom icon, using css and custom font, but outside of the scope of what I'm willing to implement in the plugin. |
I think I have this issue resolved with the above commit and available as version 1.0.0rc1. You can change the release channel for the plugin to |
I am probably missing something obvious but... I just installed Tab Order and I can't get the icons to work.
Do I need to download the icons from fontawsome and if so where do I put them?
Thanks for all the work you have put into your plugins.
Cheers DG
The text was updated successfully, but these errors were encountered: