Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Clone bounds on Serialize impls #71

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Mar 8, 2024

The impls are not really useful for non-Clone types, but this allows deriving Serialize for types with fields of type imbl::Container<GenericParameter> without #[serde(bound)] overrides for the generates impls.

@jplatte
Copy link
Contributor Author

jplatte commented Mar 8, 2024

Would be nice to do the same for Deserialize but that would require first removing the unnecessary Clone bounds for From<StdContainer<T>> for imbl::Container<T> / FromIterator<T> for imbl::Container<T>, which is probably not straight-forward.

Copy link
Owner

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jneem jneem merged commit f97eb5c into jneem:main Mar 11, 2024
16 checks passed
@jplatte jplatte deleted the jplatte/serialize branch March 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants