Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtle (and probably premature) note about destroying mechanism (potential memory leaks source) #33

Open
davidedc opened this issue Nov 24, 2015 · 0 comments

Comments

@davidedc
Copy link

looks like the current "destroy" implementations are non-recursive. One (or a few) nodes are severed from the tree.

While this removes an entire branch from the world in terms of visibility and interaction, there could be a memory leak if destroyed morphs "down the branch" are targets of living morphs, or if callbacks from living objects reference them.

A recursive destroy would give the chance to check such links (which could prevent the morphs from being garbage-collected) and decide what to do about them.

Probably not a material concern, but if a leak is observed, this could be a place where it could come from...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant