From 03c72e6ee1fa448bf655611161cf5b95950837af Mon Sep 17 00:00:00 2001 From: John Chilton Date: Wed, 13 Nov 2024 13:58:28 -0500 Subject: [PATCH] Selenium fixes for parameter validation changes. --- lib/galaxy_test/selenium/test_tool_form.py | 12 ++++++------ lib/galaxy_test/selenium/test_workflow_editor.py | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/galaxy_test/selenium/test_tool_form.py b/lib/galaxy_test/selenium/test_tool_form.py index 42740dd72044..2d653ef04c4e 100644 --- a/lib/galaxy_test/selenium/test_tool_form.py +++ b/lib/galaxy_test/selenium/test_tool_form.py @@ -191,9 +191,9 @@ def test_rerun_deleted_dataset(self): error_col = self.components.tool_form.parameter_error(parameter="col").wait_for_visible() assert ( error_input1.text - == "parameter 'input1': the previously selected dataset has been deleted. Using default: ''." + == "Parameter 'input1': the previously selected dataset has been deleted. Using default: ''." ) - assert error_col.text == "parameter 'col': an invalid option ('3') was selected (valid options: 1)" + assert error_col.text == "Parameter 'col': an invalid option ('3') was selected (valid options: 1)" # validate errors when inputs are missing self.components.tool_form.parameter_data_input_collection(parameter="input1").wait_for_and_click() self.sleep_for(self.wait_types.UX_TRANSITION) @@ -201,8 +201,8 @@ def test_rerun_deleted_dataset(self): error_col = self.components.tool_form.parameter_error(parameter="col").wait_for_visible() error_col_names = self.components.tool_form.parameter_error(parameter="col_names").wait_for_visible() assert error_input1.text == "Please provide a value for this option." - assert error_col.text == "parameter 'col': requires a value, but no legal values defined" - assert error_col_names.text == "parameter 'col_names': requires a value, but no legal values defined" + assert error_col.text == "Parameter 'col': requires a value, but no legal values defined" + assert error_col_names.text == "Parameter 'col_names': requires a value, but no legal values defined" # validate warnings when inputs are restored self.components.tool_form.parameter_data_input_single(parameter="input1").wait_for_and_click() self.sleep_for(self.wait_types.UX_TRANSITION) @@ -210,9 +210,9 @@ def test_rerun_deleted_dataset(self): error_col = self.components.tool_form.parameter_error(parameter="col").wait_for_visible() assert ( error_input1.text - == "parameter 'input1': the previously selected dataset has been deleted. Using default: ''." + == "Parameter 'input1': the previously selected dataset has been deleted. Using default: ''." ) - assert error_col.text == "parameter 'col': an invalid option ('3') was selected (valid options: 1)" + assert error_col.text == "Parameter 'col': an invalid option ('3') was selected (valid options: 1)" @selenium_test def test_rerun_dataset_collection_element(self): diff --git a/lib/galaxy_test/selenium/test_workflow_editor.py b/lib/galaxy_test/selenium/test_workflow_editor.py index ececfacac313..114e5101fcba 100644 --- a/lib/galaxy_test/selenium/test_workflow_editor.py +++ b/lib/galaxy_test/selenium/test_workflow_editor.py @@ -546,7 +546,7 @@ def test_editor_subworkflow_tool_upgrade_message(self): self.components.workflows.edit_button.wait_for_and_click() self.sleep_for(self.wait_types.UX_RENDER) self.assert_modal_has_text("Using version '0.2' instead of version '0.0.1'") - self.assert_modal_has_text("parameter 'inttest': an integer or workflow parameter is required") + self.assert_modal_has_text("Parameter 'inttest': an integer or workflow parameter is required") self.screenshot("workflow_editor_subworkflow_tool_upgrade") self.components.workflow_editor.modal_button_continue.wait_for_and_click() self.assert_workflow_has_changes_and_save()