Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skills increase don't handle wrap around. #78

Open
jlnunez89 opened this issue Jul 30, 2020 · 1 comment
Open

Skills increase don't handle wrap around. #78

jlnunez89 opened this issue Jul 30, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jlnunez89
Copy link
Owner

jlnunez89 commented Jul 30, 2020

Problem

When a skill is increased, a value by which to increase the current count is supplied.
That value is only accounted for up until the next skill level and the count is reset to the beginning of that 'next level'.
i.e. when a skill advances, the percent is always reset to zero when in reality, it should be left at where the increase lands it.

Solution

The added value should 'wrap around' such that multiple skill level advances are possible by increasing by a big enough value.
This should be addressed in Fibula.Creatures/Skill.cs and Fibula.Creatures/MonsterSkill.cs respectively.

@jlnunez89 jlnunez89 added the good first issue Good for newcomers label Jul 30, 2020
@jlnunez89
Copy link
Owner Author

leaving up for grabs since it's a good first issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant