Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoTest GHA Doesn't Trigger On PRs from outside contributors #282

Open
jlewi opened this issue Oct 8, 2024 · 0 comments
Open

GoTest GHA Doesn't Trigger On PRs from outside contributors #282

jlewi opened this issue Oct 8, 2024 · 0 comments

Comments

@jlewi
Copy link
Owner

jlewi commented Oct 8, 2024

https://github.com/jlewi/foyle/pulls

The "go test and build" workflow is stuck in the "golang test & build Expected — Waiting for status to be reported".

The docs say I should see an approval button but I don't.
https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks#approving-workflow-runs-on-a-pull-request-from-a-public-fork

Screen Shot 2024-10-07 at 7 17 24 PM

I think the issue could be that in my workflow. I trigger on push

But not pull request. Since its coming from a fork there presumably isn't a push event to a branch in the repository.

jlewi added a commit that referenced this issue Oct 8, 2024
* Right now the GHA doesn't trigger for PRs created from forks.
* Update the GHA to trigger on pull_request

Related to #282
jlewi added a commit that referenced this issue Oct 8, 2024
* Right now the GHA doesn't trigger for PRs created from forks.
* Update the GHA to trigger on pull_request

Related to #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant