Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Content-Length miscalculation #61

Open
jjg opened this issue Jun 16, 2015 · 0 comments
Open

Potential Content-Length miscalculation #61

jjg opened this issue Jun 16, 2015 · 0 comments

Comments

@jjg
Copy link
Owner

jjg commented Jun 16, 2015

When a HEAD request is made for a file, I noticed a discrepancy between the Content-Length and the X-Media-Size headers of 8 bytes. X-Media-Size comes from inspection of the uploaded file's internal structure whereas Content-Length is calculated as the file is uploaded.

Line 296 in server.js:

this.file_metadata.file_size = this.file_metadata.file_size + this.input_buffer.length;

I'm wondering if the line above is "padding" the end of the stored file by including empty buffer?

@jjg jjg added bug question and removed bug labels Jul 16, 2015
@jjg jjg modified the milestone: 10xi Beta 2 Aug 21, 2015
@jjg jjg added the old label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant