-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moderator on moderated.jitsi.net not supported (redirect issue) #705
Comments
Good point. We probably need to change things around and do a HEAD request to resolve the real URL... And then parse the jwt and pass it along. A PR in this space would be welcome. |
Thx for replying. Could you make that PR for me?
I do now know how to do that...
Since I, and yourself, seem to agree in this point here.
Another suggestion I would give is NOT to allow jitsi-electron to send
an invitation to join a certain room without the person who opened the room to set a password before sending the invitation...
…-------------------------------
On Tue, Feb 08, 2022 at 07:42:18AM -0800, Saúl Ibarra Corretgé wrote:
Good point. We probably need to change things around and do a HEAD
request to resolve the real URL... And then parse the jwt and pass it
along.
A PR in this space would be welcome.
—
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.
Triage notifications on the go with GitHub Mobile for [3]iOS or
[4]Android.
You are receiving this because you authored the thread. Message ID:
***@***.***>
References
1. #705 (comment)
2. https://github.com/notifications/unsubscribe-auth/AKLPRKK3YXOGRY35PQTQZH3U2E2VVANCNFSM5N2WGTTA
3. https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
4. https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign=notification-email&utm_medium=email&utm_source=github
|
Will do when I have some time.
There is no reason to enforce that, it's the user's responsibility. |
While revisiting this and checking how moderated.jitsi.net works, I don't see a way how to enable this into the electron app. moderated.jitsi.net hides the real URL with JWT and only redirects to it when clicking a button: Source: https://github.com/jitsi/moderated-meetings/blob/master/src/main/js/screens/Join.tsx#L152-L157 So unless this is changed in moderated.jitsi.net to directly expose the URL containing the JWT, I don't see how this would work in the electron app. Any suggestions @saghul? |
@csett86 Yep, you're right. We'd need to add a way to copy the real link. |
@saghul I could provide an updated implementation as PR for the moderated-meetings that looks like this: This changes the room names to url sanitized base64 (ie "/" -> "-" and "+" -> "_") names so that the room names are shorter and then extends the view to 720px so that the normal and moderator URL also look different. What do you think? |
Its not a good idea, it would break all existing moderated meetings by assigning them a new room. I‘ll try a different route |
Thanks for looking into this. |
I think I got something now that allows to share the moderation link and also keeps backwards compatibility: |
How can I have moderator powers in jitsi-meet-electron?
Do you provide this feature?
https://moderated.jitsi.net/
If not, could you add it?
Thx
The text was updated successfully, but these errors were encountered: