Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when burrow expires a consumer group, the exporter does not (always?) remove it #17

Open
ehthayer opened this issue Apr 26, 2018 · 5 comments

Comments

@ehthayer
Copy link

The blue rectangle in the attached graph is one of these cases. It stops after burrow exporter was bounced.
screen shot 2018-04-26 at 8 48 02 am

@elukey
Copy link

elukey commented May 17, 2018

I can confirm the issue, happened the same to me as well..

Seems to be an issue with the Prometheus libs, a found a similar use case in prometheus/client_python#182. By design the behavior outlined in this issue seems to be the expected one, namely metrics cannot appear/disappear during the lifetime of the exporter process. I have no idea if there is a workaround for the go_client, but I'd add a not in the documentation explaining the problem so others will be aware.

@jirwin
Copy link
Owner

jirwin commented Aug 16, 2018

I think this is part of the nature of prometheus. I don't know of any way to remove an individual timeseries from the exporter(at runtime). We can unregister the collector, but that is not what we want to do.

I'll look into it a bit more and see if there is anything we can do.

@shamil
Copy link

shamil commented May 13, 2019

If still relevant, I've refactored the exporter to use prometheus custom collector implementation, which will solve the issue with stale metrics.

Since it's a refactor my repo was hard-forked from this one. Thanks @jirwin for your work.

@whaike
Copy link

whaike commented Jul 18, 2019

I removed one Topic from kafka ,but burrow-exporter still have old topic metrics with unchanging values untill reboot burrow-exporter.

@saumyadoogar
Copy link

Im also facing this issue, its fairly common to see consumers that no longer exist,
restarting the exporter fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants