Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error in reimplementation #8

Open
vvigilante opened this issue Feb 18, 2020 · 0 comments
Open

Possible error in reimplementation #8

vvigilante opened this issue Feb 18, 2020 · 0 comments

Comments

@vvigilante
Copy link

With reference to the original implementation
https://github.com/kracwarlock/action-recognition-visual-attention/blob/6738a0e2240df45ba79e87d24a174f53adb4f29b/src/actrec.py#L111

it looks like to me that they use this structure for decoding the lstm:
Dense(100) -> tanh -> Dense(n_classes) -> softmax
while you implemented in the function _decode_lstm:
Dense(n_classes) -> tanh -> Dense(n_classes) -> softmax

I think that the first, hidden fully connected layer has too few neurons, and that is it different from the original implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant