Address field_access_terms tickets and a few minor things #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2021 07:17
Makes field_access_terms a required field. Adds field_access_terms to media tests.
Makes field_access_terms a required field. Adds field_access_terms to media tests.
|
|
Tweaks tests as needed.
|
fixed test data.
|
Fixes errors I had created in the tests.
|
Moves "field_access_terms" out of the default display for repository item and collection object
|
bseeger
changed the title
|
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket addresses #110 and #125.
Specifically, it:
field_access_termsto media testsfield_access_termsa required field on all entities, and adjusts test code as needed, to include the field.Other things this does related to those tickets, but not specifically outline in those them:
member_offield a single value field, since we can only put an item in one collection. This prevents admins from putting items in more that one collection, as our system is not setup to handle it.field_access_termsfield have same permission as other fields (it had had custom perms before, but not sure they are necessary).field_access_termsfrom the default display for collection and repository items. This means they will not be part of the data shown in the UI to end-users. They can still be grabbed via the JSON API. This just makes it so that field's data doesn't show up on the repository item page in the metadata. I ran this past Katie before doing this and she thinks this is a good idea.This last change is on drupal: when I export the drupal config, it changes a line in the contact_email ingest. Drupal does this to line up the
idwith the filename. We may as well fix this here. If not, than we should make a ticket to clean this up.