Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it important to have a "book view" for paged content? #448

Open
jabrah opened this issue Nov 12, 2021 · 2 comments
Open

Is it important to have a "book view" for paged content? #448

jabrah opened this issue Nov 12, 2021 · 2 comments
Labels
question Further information is requested UI wontfix This will not be worked on

Comments

@jabrah
Copy link

jabrah commented Nov 12, 2021

Currently, paged content is rendered using Mirador, but is configured in a way that will display only one image at a time. Is it important to view paged content with the left and right sides of an opening visible side by side?

Here's an example from the Mirador instance used in AoR:

Single view

image

"Book" view

image

If we want to enable the book view, I believe we'd need to add a viewingHint: paged to the generated IIIF sequences (this can be done in idc_ui_module/plugin/views/style/IDCIIIFSerializer)

@jabrah jabrah added question Further information is requested UI labels Nov 12, 2021
@htpvu
Copy link

htpvu commented Mar 4, 2022

acceptance testing had not raised an issue with our current pdf display. So we wont take on this work unprompted.

@htpvu htpvu added the wontfix This will not be worked on label Mar 4, 2022
@jabrah
Copy link
Author

jabrah commented Mar 22, 2022

This would be applicable to Paged Content repository items.\

Firstly, we would need to update our generated IIIF manifests to add the viewingHint: 'Paged' on the Sequence (only on Paged Content items) here in this PHP file: https://github.com/jhu-idc/idc_ui_module/blob/main/src/Plugin/views/style/IDCIIIFSerializer.php

We'd need to modify our Mirador config (https://github.com/jhu-idc/idc-ui-theme/blob/main/js/packages/mirador/index.js#L35-L65), by adding

config.window.views = [
  { key: 'single', behaviors: ['individuals'] },
  { key: 'book', behaviors: ['paged'] },
];
config.window.allowTopMenuButton = true; // Change from 'false' to 'true'

This will add a button to the top menu, which, when clicked, will open a control panel that would let a user choose view modes.
image.

Optionally, we could change config.windows.view to 'book'``, from 'single'`. This would show the "book" view by default instead of the single image view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested UI wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants