Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Xmx Java args to allow Java to scale memory to container limit #381

Open
birkland opened this issue Jul 19, 2021 · 1 comment
Open

Comments

@birkland
Copy link

See description in: https://www.atamanroman.dev/articles/usecontainersupport-to-the-rescue/

Essentially, as long as -Xmx is not defined Java will automatically use 1/4 the container memory limit for the heap size. Since isle-buildkit does define -Xmx, we need to remove it, in order to allow the JVM to auto-size.

Resource limits are introduced in idcApp-k8s as of jhu-idc/idcApp-k8s#57

@htpvu
Copy link

htpvu commented Mar 4, 2022

I have no idea where this work should be done. THis ticket does not look like it should block the feature completion launch from the DRCC team. But a review of this by a developer post launch would probably be a good idea.

@htpvu htpvu added the LAG label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants