Added LIST_allocator API #74
Conversation
This API is used in LIST_cons_gl() to allocate list memory. Also, added error handling logic for this API Now, LIST_DEFAULT_ALLOCF macro can be used to replace memory allocation function for LIST header (default value: malloc) Modified LIST_HEADER_VERSION to 0.1.1
#undef LIST_allocator
There was a problem hiding this comment.
The changes are well meant and make sense, but I can't accept this as of now because I don't yet know how I'd prep the new API.
I still haven't considered many options, like:
-
Should the custom definition override
mallocfor the_gl()family? (In this PR: yes) -
Should a separate set with a different suffix be added? (In this PR: no)
-
Should it use a predefinition macro so that you can customise it at time of definition? (In this PR: missing the
ifndef) -
Should it be customisable per-list, or per-program? (In this PR: per list)
This change is not planned for very soon. At the moment, I'm not sure how to proceed on this. I hope you can understand.
No problem. Just close this as invalid or not-planned. Also, I am not sure if following in this PR were necessary:
Yes i can understand. I was also feeling that something is missing while submitting this PR. |
|
Thanks for understanding. In a close future when the wanted API design is more clear, we can work this out. |
This API is used in LIST_cons_gl() to allocate list memory.
Also, added error handling logic for this API.
Now, LIST_DEFAULT_ALLOCF macro can be used to replace memory allocation function for LIST header (default value: malloc)
These changes are an attempt to resolve #69
Modified LIST_HEADER_VERSION to 0.1.1