Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit - accept working dirs for IaC/Secrets scanners #884

Merged
merged 16 commits into from
Aug 14, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Aug 2, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

The audit command will now accept passing working directories through the --working-dirs flag for the IaC and Secrets scanners as well.
Currently, IaC supports only one working directory. However, passing multiple working directories for the Secrets scanner is possible.

@omerzi omerzi added the improvement Automatically generated release notes label Aug 2, 2023
omerzi added 2 commits August 2, 2023 14:51
…accept-wd-for-iac-secrets

# Conflicts:
#	xray/audit/jas/secretsscanner_test.go
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add working dirs also to CLI full audit tests

go.mod Outdated Show resolved Hide resolved
xray/audit/jas/iacscanner.go Outdated Show resolved Hide resolved
xray/audit/jas/iacscanner.go Outdated Show resolved Hide resolved
xray/audit/jas/iacscanner.go Outdated Show resolved Hide resolved
xray/audit/jas/secretsscanner_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
xray/audit/jas/applicabilitymanager.go Show resolved Hide resolved
xray/audit/jas/applicabilitymanager.go Outdated Show resolved Hide resolved
xray/audit/jas/applicabilitymanager_test.go Outdated Show resolved Hide resolved
xray/audit/jas/jasmanager.go Show resolved Hide resolved
@omerzi omerzi temporarily deployed to frogbot August 14, 2023 14:51 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@omerzi omerzi merged commit 542dc7a into jfrog:dev Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants