review changes

jfrog · Aug 30, 2023 · d75f3bf · d75f3bf
1 parent b161d9e
commit d75f3bf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/xray/utils/analyzermanager.go b/xray/utils/analyzermanager.go
@@ -22,7 +22,7 @@ import (
 type SarifLevel string
 
 const (
-	Err     SarifLevel = "error"
+	Error   SarifLevel = "error"
 	Warning SarifLevel = "warning"
 	Info    SarifLevel = "info"
 	Note    SarifLevel = "note"
@@ -34,9 +34,9 @@ const (
 var (
 	// All other values (include default) mapped as 'Medium' severity
 	levelToSeverity = map[SarifLevel]string{
-		Err:  "High",
-		Note: "Low",
-		None: "Unknown",
+		Error: "High",
+		Note:  "Low",
+		None:  "Unknown",
 	}
 )
 
@@ -248,7 +248,7 @@ func ExtractRelativePath(resultPath string, projectRoot string) string {
 
 func GetResultSeverity(result *sarif.Result) string {
 	if result.Level != nil {
-		if severity, ok := levelToSeverity[SarifLevel(*result.Level)]; ok {
+		if severity, ok := levelToSeverity[SarifLevel(strings.ToLower(*result.Level))]; ok {
 			return severity
 		}
 	}

diff --git a/xray/utils/analyzermanager_test.go b/xray/utils/analyzermanager_test.go
@@ -3,11 +3,12 @@ package utils
 import (
 	"errors"
 	"fmt"
+	"path/filepath"
+	"testing"
+
 	"github.com/jfrog/jfrog-cli-core/v2/utils/coreutils"
 	"github.com/owenrumney/go-sarif/v2/sarif"
 	"github.com/stretchr/testify/assert"
-	"path/filepath"
-	"testing"
 )
 
 func TestRemoveDuplicateValues(t *testing.T) {
@@ -115,7 +116,7 @@ func TestExtractRelativePath(t *testing.T) {
 }
 
 func TestGetResultSeverity(t *testing.T) {
-	levelValueHigh := string(Err)
+	levelValueHigh := string(Error)
 	levelValueMedium := string(Warning)
 	levelValueMedium2 := string(Info)
 	levelValueLow := string(Note)