removing expectedOverride in tests as it is not supposed to be changed

jfrog · Nov 4, 2024 · c4b71b2 · c4b71b2
1 parent b561ef9
commit c4b71b2
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/plugins/components/conversionlayer_test.go b/plugins/components/conversionlayer_test.go
@@ -19,7 +19,6 @@ func TestCreateCommandUsages(t *testing.T) {
 	strFlag := NewStringFlag("flag", "", SetMandatory())
 
 	override := []string{"usage override", "usage override 2", "usage override 3"}
-	expectedOverride := override
 
 	tests := []struct {
 		name        string
@@ -88,7 +87,7 @@ func TestCreateCommandUsages(t *testing.T) {
 				UsageOptions: &UsageOptions{Usage: override},
 			},
 			stringFlags: map[string]StringFlag{optStrFlag.Name: optStrFlag},
-			expected: append(expectedOverride,
+			expected: append(override,
 				fmt.Sprintf("%s [command options] <%s> <%s>", expectedPrefix, "first argument", "second"),
 				fmt.Sprintf("%s [command options] --%s=<%s> <%s>", expectedPrefix, optStrFlag.Name, optStrFlag.HelpValue, "first argument"),
 			),
@@ -102,7 +101,7 @@ func TestCreateCommandUsages(t *testing.T) {
 				UsageOptions: &UsageOptions{Usage: override, ReplaceAutoGeneratedUsage: true},
 			},
 			stringFlags: map[string]StringFlag{optStrFlag.Name: optStrFlag, strFlag.Name: strFlag},
-			expected:    expectedOverride,
+			expected:    override, //override is not expected to be changed upon using UsageOptions
 		},
 	}