Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying an existing bookmark through slash command is not optimal #73

Open
jfrerich opened this issue May 4, 2020 · 0 comments
Open
Labels
enhancement New feature or request Tech/Go
Milestone

Comments

@jfrerich
Copy link
Owner

jfrerich commented May 4, 2020

Once a bookmark exists, modifying the bookmark with the /bookmarks add command overwrites the bookmark and does not provide an update option.

slash command

1) In the following scenario, the labels are added, but not the title

repro:

  • /bookmarks add <postId>
  • /bookmarks add <postId> Add a title --labels=<newlabel1>,<newlabel2>

2) In the following scenario, label2 is dropped and user is not informed. Here we should automatically add the existing labels when --labels used, or show the user the differences in the bookmarks before and after in an ephemeral message, showing them the differences

repro:

  • /bookmarks add <postId>
  • /bookmarks add <postId> Add a title --labels=<newlabel1>,<newlabel2>
  • /bookmarks add <postId> Add a title --labels=<newlabel1>

possible suggestion

Once the UI is merged, add to the ephemeral message of a /bookmarks add command letting the user know the UI exists and is easier to modify bookmarks

@jfrerich jfrerich added enhancement New feature or request Tech/Go labels May 4, 2020
@jfrerich jfrerich added this to the v0.1.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Tech/Go
Projects
None yet
Development

No branches or pull requests

1 participant