Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the addition of an automated quality control feature #55

Open
LuisOlivaresJ opened this issue Oct 30, 2024 · 4 comments
Open

About the addition of an automated quality control feature #55

LuisOlivaresJ opened this issue Oct 30, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@LuisOlivaresJ
Copy link
Collaborator

Hi @jfcabana and @petruong,

I enjoyed reading an article since, as mentioned in the conclusions, it would be helpful to have an automated quality control system during each reading.
I was thinking about incorporating optical filters in each reading (for example on the center of the scanner and on the sides). OMG should automatically identify the filters and compare the optical density of the filters with reference values (for example to the values during film calibration).

What do you think?

@LuisOlivaresJ LuisOlivaresJ added the enhancement New feature or request label Oct 30, 2024
@jfcabana
Copy link
Owner

jfcabana commented Nov 7, 2024

Hi Luis,
I haven't had the time to read the paper, but the idea is interesting. I'm not sure how easily feasible it would be though. Another approach that might be simpler would be the two-point calibration correction described in this paper. @petruong recently talk to me about this, I don't know if he worked on something yet? It is similar to what we are already doing when applying a correction factor from a reference film, but it also introduces a 0 dose reference to better correct the slope of the calibration curve. That should be simple to implement.

@petruong
Copy link
Collaborator

petruong commented Nov 7, 2024

Hello there @LuisOlivaresJ,

I wanted to take a bit more time in order to do a better reading of the paper you referenced before responding (understanding of the applicability/advantages for utilizing optical filters in the film scan/analysis process), but as @jfcabana mentioned, we briefly discussed the incorporation of the optical density (dose) reading for the proposed zero dose reference film (from the same film calibration lot) in order to account for the aging/drift in the calibration LUT. Nothing has been implemented yet, but the brief idea would be to take the normalization factor (a = normalization film median dose / expected film dose) applied to the film dose points subtracted by the reference zero median dose (b): Corrected dose = (a * dose_film) - b
For reference, the current algorithm is as such: Corrected dose = a * dose_film

In your case for optical filter included in the scanning process (I imagine encompassing the zero and irradiated film region), the reference zero median dose (b) factor would take this into account (i.e., zero dose being the optical filter applied). Though, the biggest challenge would be if the optical density is way outside the range of the calibration LUT, in which this "b" dose would be heavily extrapolated outside calibration dose points.

I mention all this, because I plan on going on paternity leave in the coming weeks, so no progress on this reference zero dose factor on my part for the time being.

Cheers,
Peter

@LuisOlivaresJ
Copy link
Collaborator Author

Hi,

The idea of using optical filters is to have a quality control mechanism to identify potential errors during the scanning process (for example if auto correction of color or brightness has been applied unconsciously). Also, as a way to measure inter-scan reproducibility of the lamp/detector system. Optical density measurements of the filters should not be used to create corrections factors.
By the other hand, as you said, to account for aging/drift and also for inter-scan variations, the use of the optical density of the zero dose film is a better approach.

@jfcabana
Copy link
Owner

Ah I see what you're talking about now. Yes using optical filters just as a reference for detecting potential errors might be a good idea. A downside would be that it would require to always scan a larger area of the scanner to encompass this filter, but it is probably not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants