Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Dependencies as submodules #116

Open
psiha opened this issue Apr 11, 2023 · 3 comments
Open

[FEATURE] Dependencies as submodules #116

psiha opened this issue Apr 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@psiha
Copy link
Contributor

psiha commented Apr 11, 2023

Switch to using dependencies (such as kumi) as submodules (or packages or...) instead of as 'flattened detail headers'.
(makes collaboration easier)

@psiha psiha added the enhancement New feature or request label Apr 11, 2023
@jfalcou
Copy link
Owner

jfalcou commented Apr 16, 2023

is CPM + cmake level option to control yes/no on dependencies ok for your use case ?

@jfalcou
Copy link
Owner

jfalcou commented Jul 5, 2023

TTS and other sub-level dependencies are being rewritten at the infrastructure level to garantee usage like this.
We'll end up using CPM to drag them as it is working properly with normal FIndPackage level + we'll adda -DKWK_EXTERNAL_DEPENDENCIES option to skip it entirely

@jfalcou jfalcou pinned this issue Jul 6, 2023
@jfalcou
Copy link
Owner

jfalcou commented Aug 20, 2023

eve, tts, kumi and raberu are now fetchable via CPM.
SO next step is to amend Kwiaku to use CPM to fetch them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants