[FEATURE] shape construction from std span and initializer_list

[psiha]

via constructors or make/factory function (to avoid std::vector style () vs {} construction ambiguities)

[jfalcou]

this can be bolted onto of_size

[psiha]

(this is useful for unit tests)

[jfalcou]

OK std::span can have a static size so we now the # of dimensions of the result.

BUT the size of an initializer_list is not so we need to force it ?

[psiha]

OK std::span can have a static size so we now the # of dimensions of the result.

BUT the size of an initializer_list is not so we need to force it ?

huh neither span nor initializer_list have a static size? (except if you mean in a constexpr context)
so yes, you have to assert that the size matches

[jfalcou]

std::span<T,N> is a thing actually.

Assert that it matches with what ?

in the case of of_size({x,y,z]); ?
Or it means we need of_size(_3D, {x,y,z])`

[psiha]

std::span<T,N> is a thing actually.

oh right :D

Assert that it matches with what ?

that the runtime size matches the static size

in the case of of_size({x,y,z]); ? Or it means we need of_size(_3D, {x,y,z])`
yes you'd need the type

• a constructor or
• or member static factory
• free func with a template parameter