New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to easily configure a ByteBufferPool #116

Open

lorban opened this issue Feb 7, 2022 · 0 comments

Labels

Member

lorban commented Feb 7, 2022

The LoadGenerator.Builder currently lacks an easy way to set a ByteBufferPool, something like the following:

LoadGenerator.builder()
    .byteBufferPool(bufferPool)
...

Currently the only way to set the byte buffer pool is by configuring a httpClientTransportBuilder which requires:

9.4.x: overriding the HTTPClientTransportBuilder's build() method to create a HttpClient and set the byte buffer pool on it.
10/11: overriding the HTTPClientTransportBuilder's getConnector() method to return a custom ClientConnector that has the byte buffer pool set on it. This has the side effect of ignoring the LoadGenerator.Builder's configured sslContextFactory which must be manually set on the custom ClientConnector.

None of this is straightforward nor easy to remember.

The text was updated successfully, but these errors were encountered:

lorban added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment