Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACR Tokens support for authentication #80

Open
Flasheh opened this issue Aug 20, 2021 · 2 comments
Open

ACR Tokens support for authentication #80

Flasheh opened this issue Aug 20, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Flasheh
Copy link

Flasheh commented Aug 20, 2021

The feature is still in preview, but you can generate tokens for ACR that are (optionally) scoped to specific repositories and with limited permissions.

Having the ability to use these tokens for authentication would be a huge improvement.

Docs:
https://docs.microsoft.com/en-us/azure/container-registry/container-registry-repository-scoped-permissions

@davidcollom davidcollom added enhancement New feature or request help wanted Extra attention is needed labels Jul 12, 2023
@davidcollom
Copy link
Collaborator

Hey @Flasheh,

Sorry that its taken so long to respond - I'm not 100% fermilier with Azure, but this looks like its a key/token per repo, which would mean we'd need to have something similar to the selfHosted approach of multiple keys.

This isn't too much of an issue to implement, if you could confirm my understanding I'd be happy to implement this.

FWIW - I have been planning/looking this week to get version-checker to support ManagedIdentity and native AKS Identity / WorkloadIdentity via the azure go SDK.

@Flasheh
Copy link
Author

Flasheh commented Jul 4, 2024

hi @davidcollom

As it's been a while I don't exactly remember what the issue was with the ACR tokens. The authentication might also have changed on azure's side since it was still in preview back then. And I'm not currently using this project anywhere to do a quick test.

ACR tokens are linked to scope maps which are a set of repository-level permissions. They can be scoped to one or many repos. So tokens aren't necessarily per repo.

I'd say supporting Entra-based identities like managed IDs should probably have a higher priority. As the only real advantage of using tokens at the moment is the ability to implement repo-level permissions. But I do know there's a feature on the ACR roadmap to support similar functionality for managed IDs though. In which case token support would no longer be needed. At least for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants