Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Missing container metrics with multiple containers in a pod #274

Open
oGi4i opened this issue Sep 22, 2024 · 0 comments · May be fixed by #275
Open

[BUG] Missing container metrics with multiple containers in a pod #274

oGi4i opened this issue Sep 22, 2024 · 0 comments · May be fixed by #275
Assignees
@davidcollom
Labels
bug Something isn't working

Comments

@oGi4i
Copy link

oGi4i commented Sep 22, 2024 •
edited
Loading

Describe the bug
If a pod has more than 1 container than there is only 1 metric reported

To Reproduce
Steps to reproduce the behavior:

  1. Deploy a pod with multiple containers and enabled version check for all of them
  2. Check Prometheus with the following Query:
version_checker_is_latest_version{exported_namespace="<your_namespace>", exported_pod="<your_pod_name>"}
  1. The actual metrics are:
version_checker_is_latest_version{container="version-checker", container_type="container", current_version="<image_2_version>", endpoint="web", exported_container="<container_name_2>", exported_namespace="<your_namespace>", exported_pod="<your_pod_name>", image="<image_2>", instance="10.255.254.150:8080", job="version-checker", latest_version="<image_2_latest_version>", namespace="version-checker", pod="version-checker-6dd5b85f7d-4s86k", service="version-checker"} = 1
  1. The expected metrics should be:
version_checker_is_latest_version{container="version-checker", container_type="container", current_version="<image_1_version>", endpoint="web", exported_container="<container_name_1>", exported_namespace="<your_namespace>", exported_pod="<your_pod_name>", image="<image_1>", instance="10.255.254.150:8080", job="version-checker", latest_version="<image_1_latest_version>", namespace="version-checker", pod="version-checker-6dd5b85f7d-4s86k", service="version-checker"} = 1
version_checker_is_latest_version{container="version-checker", container_type="container", current_version="<image_2_version>", endpoint="web", exported_container="<container_name_2>", exported_namespace="<your_namespace>", exported_pod="<your_pod_name>", image="<image_2>", instance="10.255.254.150:8080", job="version-checker", latest_version="<image_2_latest_version>", namespace="version-checker", pod="version-checker-6dd5b85f7d-4s86k", service="version-checker"} = 1

Expected behavior
1 metric is reported per container

Environment (please complete the following information):

  • Version-Checker: v0.8.0+
  • Kubernetes: v1.27.16
  • Grafana: 11.2.0
  • Prometheus: 2.54.1

Additional context
The root cause of the bug is here - using partial labels to delete metrics, which only contain namespace and pod. This actually deletes all the metrics for a pod when really we want to delete only the metric for the current container that is being checked.
You can easily add a container label to this list and it should fix the issue.
@oGi4i oGi4i added the bug Something isn't working label Sep 22, 2024
@oGi4i oGi4i linked a pull request Sep 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcollom davidcollom

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix metrics for multiple containers in a pod oGi4i/version-checker
2 participants
@davidcollom @oGi4i