Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github client uses releases rather than packages for user repositories #175

Open
ribbybibby opened this issue Apr 12, 2024 · 1 comment
Open
Labels
enhancement New feature or request
Milestone

Comments

@ribbybibby
Copy link
Member

The Github client implementation seems to use releases to infer tags for Github packages at the user scope. It may be the case that release tags and tags in a ghcr repo align, but that is not necessarily the case.

I think we should be using the Packages API rather than the Releases API.

https://docs.github.com/en/rest/packages/packages?apiVersion=2022-11-28#list-packages-for-a-user

@davidcollom
Copy link
Collaborator

The challenge with using the packages API is that projects such as kyverno/kyverno have over 8k packages, over 223 releases which makes things harder from the Packages API vs the Releases API...

The Releases API is the most efficient approach, with a potential fallback to Packages (And/Or configurable via annotations.

Githubs API Rate limiting is something to consider here! Whilst Releases vs Packages might now always align.. the vast majority of times, Releases are updated/maintained and there are significantly fewer API Calls.

However, we have no way of passing custom configurations or options to the clients right now which would increase the complexity of any PR.

@davidcollom davidcollom added the enhancement New feature or request label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants