Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard.yml error #14

Open
pyrareae opened this issue Jan 7, 2021 · 6 comments
Open

Shard.yml error #14

pyrareae opened this issue Jan 7, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@pyrareae
Copy link

pyrareae commented Jan 7, 2021

When not specifying the version of shrine.cr I get the following error:

Error in shrine:shard.yml: duplicate attribute "development_dependencies" at line 22, column 1

  20.     gitlab: arctic-fox/spectator
  21. 
  22. development_dependencies:

When locking to version 0.6.0 the errors goes away.

@matthewmcgarvey
Copy link
Contributor

This still happens:

❯ shards install -v
Resolving dependencies
git ls-remote --get-url origin
Fetching https://github.com/jetrockets/shrine.cr.git
git fetch --all --quiet
git tag --list --column=never
git ls-tree -r --full-tree --name-only refs/tags/v0.1.1 -- shard.yml
git show refs/tags/v0.1.1:shard.yml
git ls-tree -r --full-tree --name-only refs/tags/v0.1.2 -- shard.yml
git show refs/tags/v0.1.2:shard.yml
git ls-tree -r --full-tree --name-only refs/tags/v0.1.3 -- shard.yml
git show refs/tags/v0.1.3:shard.yml
git ls-tree -r --full-tree --name-only refs/tags/v0.2.0 -- shard.yml
git show refs/tags/v0.2.0:shard.yml
git ls-tree -r --full-tree --name-only refs/tags/v0.2.1 -- shard.yml
git show refs/tags/v0.2.1:shard.yml
git ls-tree -r --full-tree --name-only refs/tags/v0.2.2 -- shard.yml
git show refs/tags/v0.2.2:shard.yml
git ls-tree -r --full-tree --name-only refs/tags/v0.2.3 -- shard.yml
git show refs/tags/v0.2.3:shard.yml
Error in shrine:shard.yml: duplicate attribute "development_dependencies" at line 22, column 1

  20.     gitlab: arctic-fox/spectator
  21.
  22. development_dependencies:

@matthewmcgarvey
Copy link
Contributor

tags v0.2.3 to v0.3.3 would all need to be removed in order to avoid this specific issue since they all had two development_dependencies blocks in shard.yml.

But looking into the issue, I came across this crystal-lang/shards#374 and I'm not sure if deleting those tags would cause other problems?

@igor-alexandrov
Copy link
Member

I removed v0.2.3 and v0.3.3. Let's see how it goes.
Thanks for reporting!

@igor-alexandrov igor-alexandrov added the bug Something isn't working label Mar 31, 2021
@matthewmcgarvey
Copy link
Contributor

All the releases between those two would need to be removed as well. The issue I linked talked about how they don't remove deleted tags and I believe that's what I'm seeing as well. I don't know where to go to clean it up manually either :/

@novacoole
Copy link

Just confirming this is still occurring.

@jwoertink
Copy link

Looks like this is still happening for me:

  Fetching https://github.com/jetrockets/shrine.cr.git
Error in shrine:shard.yml: duplicate attribute "development_dependencies" at line 22, column 1

  20.     gitlab: arctic-fox/spectator
  21. 
  22. development_dependencies:
     ^

However, this only happens when there's no version or branch specified. So just doing

  shrine:
    github: jetrockets/shrine.cr

will cause the error, but

  shrine:
    github: jetrockets/shrine.cr
    branch: master

does not. The other strange thing is https://gitlab.com/arctic-fox/spectator seems to be ok... Maybe some weird cache state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants