diff --git a/Directory.Build.props b/Directory.Build.props index fc77618..bbdb95f 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -3,8 +3,8 @@ @jet @eulerfx @eiriktsarpalis @michaelliao5 and contributors Jet.com Lightweight F# wrapper for Confluent.Kafka - https://github.com/jet/confluent-kafka-fsharp - kafka;fsharp + https://github.com/jet/Jet.ConfluentKafka.FSharp + kafka fsharp Apache-2.0 Copyright © 2016-9 @@ -31,5 +31,4 @@ PreserveNewest - \ No newline at end of file diff --git a/README.md b/README.md index 7921bd3..dfba893 100644 --- a/README.md +++ b/README.md @@ -42,9 +42,9 @@ Please note the [QuickStart](quickstart) is probably the best way to gain an ove NB The tests are reliant on a `TEST_KAFKA_BROKER` environment variable pointing to a test environment that will auto-create ephemeral Kafka Topics as required by the tests (each test run writes to a guid-named topic) -### build, including tests +### build, including tests on net461 and netcoreapp2.1 - dotnet build build.proj + dotnet build build.proj -v n ## FAQ diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 6669705..3659e47 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -1,4 +1,11 @@ name: $(Rev:r) + +# Summary: +# Linux: Tests with netcoreapp2.1 using docker Kafka instance +# net461 on Mono is not working, no investigation why as yet, but local run validates it +# Windows: Builds and emits nupkg as artifacts +# MacOS: Builds only + jobs: - job: Windows pool: @@ -28,7 +35,7 @@ jobs: ches/kafka sleep 15 displayName: Docker kafka for integration tests - - script: dotnet test build.proj + - script: dotnet test build.proj -v n -p:TargetFrameworks=netcoreapp2.1 # net461 fails displayName: Run Integration tests env: TEST_KAFKA_BROKER: localhost:9092 diff --git a/build.proj b/build.proj index a003f5d..ca05daf 100644 --- a/build.proj +++ b/build.proj @@ -9,8 +9,9 @@ /p:BUILD_PR=$(BUILD_PR) /p:BUILD_ID=$(BUILD_ID) $(PrOption) -o $(ThisDirAbsolute)bin/nupkg - + --logger:trx + $(TestOptions) /p:TargetFrameworks=$(TargetFrameworks) @@ -21,6 +22,6 @@ - + \ No newline at end of file diff --git a/src/Jet.ConfluentKafka.FSharp/ConfluentKafka.fs b/src/Jet.ConfluentKafka.FSharp/ConfluentKafka.fs index 76b6fcc..3ef5b6c 100644 --- a/src/Jet.ConfluentKafka.FSharp/ConfluentKafka.fs +++ b/src/Jet.ConfluentKafka.FSharp/ConfluentKafka.fs @@ -104,7 +104,7 @@ type KafkaProducer private (log: ILogger, producer : Producer, t static member Create(log : ILogger, config : KafkaProducerConfig, topic : string) = if String.IsNullOrEmpty topic then nullArg "topic" - log.Information("Producing... {broker} / {topic} compression={compression} acks={acks}", config.Broker, topic, config.Compression, config.Acks) + log.Information("Producing... {broker} / {topic} compression={compression:l} acks={acks}", config.Broker, topic, config.Compression, config.Acks) let producer = ProducerBuilder(config.Kvps) .SetLogHandler(fun _p m -> log.Information("{message} level={level} name={name} facility={facility}", m.Message, m.Level, m.Name, m.Facility))