-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests run against globally installed flood
and not current version
#716
Comments
I don't think so, we didn't install flood globally in ci flood/.github/workflows/test-backend.yml Line 47 in e36bca4
|
That's not what this ticket is about. This references NPM test https://github.com/jesec/flood/blob/master/package.json#L64 |
is doesn't, actually. it just override argv so our argv parser could parse config from it. |
this |
Pretty sure I wrote this after discovering it was running against a different version than what I had written. But I don't care enough to re-validate. IE. the ticket states
That's pretty easy to validate. But I won't do it again. |
maybe another reason causing this |
Type: Bug Report
Your Environment
Current master e20a2f0 but really any version to date.
Summary
Tests are run through
root/server/.jest/*.setup.js
usingnode flood ...
command. This fails if flood isn't globally installed.And since you're trying to validate the current development version, this is wrong anyway. It should be using
node dist/index.js ...
and have a prerequisite to have built the project (assumed to be the case in current workflows)Expected Behavior
Run tests against current development version.
Current Behavior
Tests are run against globally installed (very old) version, or "bleeding edge" master version if bodged in, but not current branch/code.
Possible Solution
See summary
Steps to Reproduce
Run
npm test
and observe behavior, check jest config files, etc.Context
Correct testing
The text was updated successfully, but these errors were encountered: