cmake: Allow to select python3 from env #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 24, 2020
This will be useful for next debian release shipping python3 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]
rzr
force-pushed
the
sandbox/rzr/python/review/master
branch
from
096f414
to
0a3af42
Compare
|
Travis job is pretty much red: https://travis-ci.org/github/jerryscript-project/iotjs/builds/711429162 I think it should be fixed first. (I'm not sure why the job status is not shown here at the PR.) |
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 24, 2020
This will be useful for next debian release shipping python3 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]
|
It looks like build is not stable, for instance this trivial change did not break: https://travis-ci.org/github/jerryscript-project/iotjs/builds/711220082 I'll rebase harmless patches. |
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 25, 2020
This will be useful for next debian release shipping python3 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected] Change-Id: Id4509a97f05eb77a40145b7aa50360b92f806fdf
rzr
force-pushed
the
sandbox/rzr/python/review/master
branch
from
0a3af42
to
d005559
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 25, 2020
This will be useful for next debian release shipping python3 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master Last-Update: 2020-07-25 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected] Change-Id: I48bf135d7a3af6e64859252078931ff3388a87a6
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 25, 2020
This will be useful for next debian release shipping python3 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected] Change-Id: Ic0db03346959f2760439aac84a0cbc166fc54d0d
rzr
force-pushed
the
sandbox/rzr/python/review/master
branch
from
d005559
to
b2b0cfe
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 27, 2020
This will be useful for next debian release shipping python3 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]
rzr
force-pushed
the
sandbox/rzr/python/review/master
branch
from
b2b0cfe
to
574a545
Compare
galpeter
reviewed
Jul 27, 2020
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jul 27, 2020
This will be useful for next debian release shipping python3 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]
rzr
force-pushed
the
sandbox/rzr/python/review/master
branch
from
574a545
to
3e75379
Compare
|
thx for finding this mistake |
This will be useful for next debian release shipping python3
Version can be specified as cmake option using:
CMAKE_OPTIONS=-DPYTHON="python3"
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/936738
Forwarded: jerryscript-project#1946
Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master
Relate-to: https://travis-ci.org/github/TizenTeam/iotjs/builds/712336077
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]
rzr
force-pushed
the
sandbox/rzr/python/review/master
branch
from
3e75379
to
91a75a2
Compare
|
I suspect a travis issue because it built my side: https://travis-ci.org/github/TizenTeam/iotjs/builds/712336077 |
rzr
added a commit
to rzr/iotjs
that referenced
this pull request
Jul 29, 2020
This will be useful for next debian release shipping python3 Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/936738 Forwarded: jerryscript-project#1946 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/python/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for next debian release shipping python3
Change-Id: Ie3a9e8ea9152247efa85a4e87bd121016a466795
Bug: #1945
Bug-Debian: https://bugs.debian.org/936738
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]