Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "match_info" field when calling combine_recombinant_info #285

Open
hyanwong opened this issue Sep 19, 2024 · 5 comments
Open

No "match_info" field when calling combine_recombinant_info #285

hyanwong opened this issue Sep 19, 2024 · 5 comments

Comments

@hyanwong
Copy link
Contributor

hyanwong commented Sep 19, 2024

The combine_recombinant_info() function in info.py references a "match_info" field in the metadata, that I don't think exists any more, so the function bombs out. We use this function for saving details of the recombination nodes for plotting.

@jeromekelleher
Copy link
Owner

The metadata has changed quite a lot, so expect breakage. I'm hoping that the format just-merged is the final one, and we can get stuff sorted out from there.

@jeromekelleher
Copy link
Owner

For now, please just hack whatever is needed to get results in the short term.

@hyanwong
Copy link
Contributor Author

hyanwong commented Sep 19, 2024

In particular, I think I need the "strain" info for recombination node matches, which was previous calculated like:

strain = match_info[0]["strain"]
assert len(match_info) == 2
assert strain == match_info[1]["strain"]

Is that the same as the strain of md["sc2ts"]["hmm"][0]["path"][0]["parent"]?

@hyanwong
Copy link
Contributor Author

Is that the same as the strain of md["sc2ts"]["hmm"][0]["path"][0]["parent"]?

Hmm, actually, I think the "strain" here is the strain of the node that "caused" this recombination to happen. I'm not sure that's in the metadata now. I'll just set it to None and hope we aren't using it for the plots.

@jeromekelleher
Copy link
Owner

I think you want causal_strain, yeah. That's in the recombinant summary data frame I'm sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants