New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for THREE.CombinedCamera #8

Open

fdiazsmith opened this issue Aug 5, 2015 · 0 comments

fdiazsmith commented Aug 5, 2015

Setup: THREE r71. and the latest of THREEx.DomEvents.
@jeromeetienne When using a THREE.CombinedCamera it does not work at all.

The fix is easy:
replace all instances of this:

if ( this._camera instanceof THREE.OrthographicCamera){/*CODE*/}
else if ( this._camera instanceof THREE.PerspectiveCamera ){/*CODE*/}

with this,

if ( this._camera instanceof THREE.OrthographicCamera || this._camera.inOrthographicMode ) {/*CODE*/}
else if ( this._camera instanceof THREE.PerspectiveCamera || this._camera.inPerspectiveMode ) {/*CODE*/}

That did it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment