You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if this is actually a problem, but wanted to make a note to look at this before finishing up with the Mongoose 7.7 upgrade.
In the static MongooseHttpClient::eventHandler(), the requests's MongooseHttpClientRequest::_client field is used to reference back to the client associated with the request. But, that _client field is only set in the MongooseHttpClientRequest ctor, and it's not checked in MongooseHttpClient::send(). It might be possible for a request to be sent through a different client than it was originally constructed with. Not sure if that's really a problem, but it seems like a potential source of weird bugs.
One fix might be to move the public send() method over to the request, since it already has an associated client.
The text was updated successfully, but these errors were encountered:
I'm not sure if this is actually a problem, but wanted to make a note to look at this before finishing up with the Mongoose 7.7 upgrade.
In the static
MongooseHttpClient::eventHandler()
, the requests'sMongooseHttpClientRequest::_client
field is used to reference back to the client associated with the request. But, that_client
field is only set in theMongooseHttpClientRequest
ctor, and it's not checked inMongooseHttpClient::send()
. It might be possible for a request to be sent through a different client than it was originally constructed with. Not sure if that's really a problem, but it seems like a potential source of weird bugs.One fix might be to move the public
send()
method over to the request, since it already has an associated client.The text was updated successfully, but these errors were encountered: