Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP]: groupId and artifactId are ignored #6839

Closed
slawekjaranowski opened this issue Jul 15, 2024 · 3 comments
Closed

[FP]: groupId and artifactId are ignored #6839

slawekjaranowski opened this issue Jul 15, 2024 · 3 comments
Labels
FP Report maven changes to the maven plugin

Comments

@slawekjaranowski
Copy link

Package URl

pkg:maven/commons-discovery/[email protected]

CPE

cpe:2.3:a:spirit-project:spirit:0.2:::::::*

CVE

No response

ODC Integration

{"label"=>"Maven Plugin"}

ODC Version

10.0.2

Description

Looks like only version is used, but groupId and artifactId are ignored.
It can be more general problem

Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>commons-discovery</groupId>
   <artifactId>commons-discovery</artifactId>
   <version>0.2</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #6839
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/commons-discovery/commons-discovery@.*$</packageUrl>
   <cpe>cpe:/a:spirit-project:spirit</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/9941750630

@github-actions github-actions bot added the maven changes to the maven plugin label Jul 15, 2024
@aikebah
Copy link
Collaborator

aikebah commented Aug 27, 2024

approved

@slawekjaranowski It's not about ignoring groupId/artifactId, It's about no CVE being registered against commons-discovery yet and therefor an improper CPE match is found to be 'best matching CPE' for the combination of evidences gathered from the dependency and the CPEs found in the NVD CVE data. If there had been a CVE registered against commons-discovery that would've resulted in a much better match.

Copy link
Contributor

Suppress rule has been added to the generatedSuppressions branch.

github-actions bot added a commit that referenced this issue Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FP Report maven changes to the maven plugin
Projects
None yet
Development

No branches or pull requests

2 participants