-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline support #25
base: master
Are you sure you want to change the base?
Pipeline support #25
Conversation
…oss GUI Builder and Pipeline step
Really great stuff @mazimkhan I believe we are ready to merge it once I can confirm i) the code from that testlink pull request has been released |
@@ -3,6 +3,7 @@ Test\ Project\ Name=Nome do Projeto de Testes | |||
Test\ Plan\ Name=Nome do Plano de Testes | |||
Platform\ Name=Nome da Plataforma | |||
Build\ Name=Nome do Build | |||
Build\ Custom\ Fields\ Values=Construir valores personalizados Campos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd probably be something like "Campos customizados do Build" (Build as a noun rather than the verb construir). Ditto for Spanish. Will fix after merging.
@@ -147,7 +152,7 @@ public ExecutionStatus getExecutionStatus() { | |||
/** | |||
* Calculates the new value of this wrapped test case execution status, | |||
* given a number of custom fields. | |||
* @param numberOfCustomFields | |||
* @param keyCustomFieldName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!!! :D
@@ -270,7 +270,7 @@ | |||
<dependency> | |||
<groupId>br.eti.kinoshita</groupId> | |||
<artifactId>testlink-java-api</artifactId> | |||
<version>1.9.14-0</version> | |||
<version>1.9.14-1-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason for using 1.9.14-1-SNAPSHOT? Which version of TestLink did you test your code against, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind the reason for using the snapshot. Probably you were using your local version with the buildCustomFields.
@@ -59,6 +59,10 @@ | |||
*/ | |||
protected String buildName; | |||
/** | |||
* The Build custom fields. | |||
*/ | |||
protected String buildCustomFields; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we merge that other pull request from testlink-java-api, we can merge this PR too.
I think there was an old review in GitHub, so I just pressed "submit review". Some conflicting files too.... sorry. |
Support for working with pipeline jobs.