Don't require node block in Pipeline #234
Comments
|
Sounds valid, but I really have no idea how to achieve this at the moment |
nathanhi
added a commit
to Draegerwerk/stashnotifier-plugin
that referenced
this issue
Dec 9, 2024
Historically, the stashNotifier plugin required a workspace context in order to perform the plugin task, albeit not making use of the workspace in any way. This change removes the implementation of the perform method requiring a workspace and replaces it with the one not requiring a workspace.
nathanhi
added a commit
to Draegerwerk/stashnotifier-plugin
that referenced
this issue
Dec 9, 2024
Historically, the stashNotifier plugin required a workspace context in order to perform the plugin task, albeit not making use of the workspace in any way. This change removes the implementation of the perform method requiring a workspace and replaces it with the one not requiring a workspace. # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Mon Dec 9 13:10:37 2024 +0100 # # On branch release/1.x # Your branch is ahead of 'origin/release/1.x' by 1 commit. # (use "git push" to publish your local commits) # # Changes to be committed: # modified: src/main/java/org/jenkinsci/plugins/stashNotifier/StashNotifier.java # modified: src/test/java/org/jenkinsci/plugins/stashNotifier/StashNotifierTest.java # # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Mon Dec 9 13:10:37 2024 +0100 # # On branch release/1.x # Your branch is ahead of 'origin/release/1.x' by 1 commit. # (use "git push" to publish your local commits) # # Changes to be committed: # modified: src/main/java/org/jenkinsci/plugins/stashNotifier/StashNotifier.java # modified: src/test/java/org/jenkinsci/plugins/stashNotifier/StashNotifierTest.java #
nathanhi
added a commit
to Draegerwerk/stashnotifier-plugin
that referenced
this issue
Dec 9, 2024
Historically, the stashNotifier plugin required a workspace context in order to perform the plugin task, albeit not making use of the workspace in any way. This change removes the implementation of the perform method requiring a workspace and replaces it with the one not requiring a workspace.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as I can tell the plugin does not need to interact with a build agent. Therefore it shall be possible to use the plugin from outside a node block.
While I can understand that you need to clone a repository to have a valid commit hash available - you may also get a valid commit hash by just loading a shared library which will not need any node block.
Furthermore for pipelines allocating multiple nodes you'll want to notify the result of the job at the very end - outside of any node block.
Hope this can be achieved easily as allocating a node may be very costly esp. on bigger Jenkins instances.
The text was updated successfully, but these errors were encountered: