From 48593c108758f4f98c1a715d90866f10ed8aa7b6 Mon Sep 17 00:00:00 2001 From: gounthar Date: Wed, 21 Feb 2024 11:00:03 +0100 Subject: [PATCH] fix(spotbugs): Primitive field selectCustomScmCommentPrefix is public and set from inside the class. It makes it too exposed. Consider making it private to limit external accessibility. [org.jvnet.hudson.plugins.m2release.M2ReleaseBuildWrapper] At M2ReleaseBuildWrapper.java:[line 93] PA_PUBLIC_PRIMITIVE_ATTRIBUTE --- .../jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java b/src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java index ff706419..d546d8ec 100644 --- a/src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java +++ b/src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java @@ -90,7 +90,7 @@ public class M2ReleaseBuildWrapper extends BuildWrapper { private String releaseEnvVar = DescriptorImpl.DEFAULT_RELEASE_ENVVAR; private String releaseGoals = DescriptorImpl.DEFAULT_RELEASE_GOALS; private String dryRunGoals = DescriptorImpl.DEFAULT_DRYRUN_GOALS; - public boolean selectCustomScmCommentPrefix = DescriptorImpl.DEFAULT_SELECT_CUSTOM_SCM_COMMENT_PREFIX; + private boolean selectCustomScmCommentPrefix = DescriptorImpl.DEFAULT_SELECT_CUSTOM_SCM_COMMENT_PREFIX; private boolean selectAppendHudsonUsername = DescriptorImpl.DEFAULT_SELECT_APPEND_HUDSON_USERNAME; public boolean selectScmCredentials = DescriptorImpl.DEFAULT_SELECT_SCM_CREDENTIALS;