Prevent triggering builds on closed PRs #865
Labels
Comments
JackPGreen
added a commit
to JackPGreen/ghprb-plugin
that referenced
this issue
Aug 19, 2024
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci#54. Fixes: jenkinsci#865
JackPGreen
added a commit
to JackPGreen/jenkinsci-plugin-ghprb
that referenced
this issue
Aug 19, 2024
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci/ghprb-plugin#54. Fixes: jenkinsci/ghprb-plugin#865
3 tasks
JackPGreen
added a commit
to JackPGreen/ghprb-plugin
that referenced
this issue
Sep 5, 2024
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci#54. I've not added a test to cover this, as there's no existing test coverage for `pull_request` events in `org.jenkinsci.plugins.ghprb.GhprbRootActionTest`, nor is there any example payloads in `org.jenkinsci.plugins.ghprb.GhprbTestUtil`. Fixes: jenkinsci#865
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What feature do you want to see added?
In #54, the comment-triggering behaviour was updated to skip closed PRs.
I think the same logic should be applied to all events (e.g. a PR being edited).
This has been flagged because builds are triggered when an issue's text is updated, even if it's closed.
Upstream changes
No response
Are you interested in contributing this feature?
No response
The text was updated successfully, but these errors were encountered: